Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

AIP-8570 remove KFP use of requests_toolbelt #301

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

talebzeghmi
Copy link
Collaborator

This release of requests-toolbelt broke the version of KFP inlined

This is to avoid the following error

❯ python metaflow/tutorials/00-helloworld/helloworld.py aip run
Metaflow zg.post2.2-11+gitfa56151 executing HelloFlow for user:talebz
Validating your flow...
    The graph looks good!
    Internal error
Traceback (most recent call last):
  File "/Users/talebz/src/zda/metaflow/metaflow/cli.py", line 1163, in main
    start(auto_envvar_prefix="METAFLOW", obj=state)
  File "/Users/talebz/src/zda/metaflow/metaflow/_vendor/click/core.py", line 829, in __call__
    return self.main(args, kwargs)
  File "/Users/talebz/src/zda/metaflow/metaflow/_vendor/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/Users/talebz/src/zda/metaflow/metaflow/_vendor/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/talebz/src/zda/metaflow/metaflow/_vendor/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/talebz/src/zda/metaflow/metaflow/_vendor/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, ctx.params)
  File "/Users/talebz/src/zda/metaflow/metaflow/_vendor/click/core.py", line 610, in invoke
    return callback(args, kwargs)
  File "/Users/talebz/src/zda/metaflow/metaflow/plugins/aip/aip_cli.py", line 265, in wrapper_common_options
    return func(args, kwargs)
  File "/Users/talebz/src/zda/metaflow/metaflow/plugins/aip/aip_cli.py", line 293, in wrapper_common_options
    return func(args, kwargs)
  File "/Users/talebz/src/zda/metaflow/metaflow/_vendor/click/decorators.py", line 33, in new_func
    return f(get_current_context().obj, args, kwargs)
  File "/Users/talebz/src/zda/metaflow/metaflow/plugins/aip/aip_cli.py", line 340, in run
    flow = make_flow(
  File "/Users/talebz/src/zda/metaflow/metaflow/plugins/aip/aip_cli.py", line 680, in make_flow
    from metaflow.plugins.aip.aip import KubeflowPipelines
  File "/Users/talebz/src/zda/metaflow/metaflow/plugins/aip/aip.py", line 14, in <module>
    import kfp
  File "/Users/talebz/miniconda3/envs/py39/lib/python3.9/site-packages/kfp/__init__.py", line 25, in <module>
    from ._client import Client
  File "/Users/talebz/miniconda3/envs/py39/lib/python3.9/site-packages/kfp/_client.py", line 35, in <module>
    from kfp._auth import get_auth_token, get_gcp_access_token
  File "/Users/talebz/miniconda3/envs/py39/lib/python3.9/site-packages/kfp/_auth.py", line 24, in <module>
    import requests_toolbelt.adapters.appengine
  File "/Users/talebz/miniconda3/envs/py39/lib/python3.9/site-packages/requests_toolbelt/adapters/appengine.py", line 42, in <module>
    from .._compat import gaecontrib
ImportError: cannot import name 'gaecontrib' from 'requests_toolbelt._compat' (/Users/talebz/miniconda3/envs/py39/lib/python3.9/site-packages/requests_toolbelt/_compat.py)

@talebzeghmi talebzeghmi requested a review from cloudw June 29, 2024 16:30
@talebzeghmi talebzeghmi merged commit 0a913d1 into feature/aip Jul 2, 2024
4 checks passed
@talebzeghmi talebzeghmi deleted the tz/AIP-8570-kfp-remove-requests_toolbelt branch July 2, 2024 20:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants